Skip to content

Conversation

@lorenzncode
Copy link
Member

Fixes #1921

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.86%. Comparing base (8f91271) to head (3822ffc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1932   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files          29       29           
  Lines        7949     7949           
  Branches     1194     1194           
=======================================
  Hits         7620     7620           
  Misses        191      191           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk
Copy link
Member

Shall we merge this PR @lorenzncode ?

@lorenzncode
Copy link
Member Author

@adam-urbanczyk The only other change I had planned was to pin the sphinx_rtd_theme to 3.1.0 when it is released.

Another idea was to move this sphinx customization out of the main cadquery repo say to CadQuery/sphinx-multimethod. The customization uses sphinx internals and will likely require changes with future updates to sphinx. I don't expect there to be very frequent maintenance of the customization however and I hope the docs remain stable pinned to sphinx 9.0.4 for some time.

Do you have any preference on keeping the customization with the docs or moving it to a separate repo?

@adam-urbanczyk adam-urbanczyk mentioned this pull request Jan 15, 2026
6 tasks
@adam-urbanczyk
Copy link
Member

@lorenzncode no opinion about it in the long run. Maybe let's merge as-is and (possibly) restructure the repo after a release?

@lorenzncode lorenzncode marked this pull request as ready for review January 17, 2026 03:42
@lorenzncode
Copy link
Member Author

@adam-urbanczyk This is ready for review/merge now.

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lorenzncode !

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks @lorenzncode !

@jmwright jmwright merged commit f3c5536 into CadQuery:master Jan 17, 2026
5 checks passed
@lorenzncode lorenzncode deleted the docs-multimethod branch January 17, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make documentation work for @multimethod functions

3 participants