-
Notifications
You must be signed in to change notification settings - Fork 405
Update sphinx multimethod customization to handle toplevel functions #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 29 29
Lines 7949 7949
Branches 1194 1194
=======================================
Hits 7620 7620
Misses 191 191
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Shall we merge this PR @lorenzncode ? |
|
@adam-urbanczyk The only other change I had planned was to pin the sphinx_rtd_theme to 3.1.0 when it is released. Another idea was to move this sphinx customization out of the main cadquery repo say to CadQuery/sphinx-multimethod. The customization uses sphinx internals and will likely require changes with future updates to sphinx. I don't expect there to be very frequent maintenance of the customization however and I hope the docs remain stable pinned to sphinx 9.0.4 for some time. Do you have any preference on keeping the customization with the docs or moving it to a separate repo? |
|
@lorenzncode no opinion about it in the long run. Maybe let's merge as-is and (possibly) restructure the repo after a release? |
|
@adam-urbanczyk This is ready for review/merge now. |
adam-urbanczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lorenzncode !
jmwright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks @lorenzncode !


Fixes #1921